[jira] [Commented] (KAFKA-5846) Use singleton NoOpConsumerRebalanceListener in subscribe() call where listener is not specified

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KAFKA-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158550#comment-16158550
 ] 

ASF GitHub Bot commented on KAFKA-5846:
---------------------------------------

GitHub user Kamal15 opened a pull request:

    https://github.com/apache/kafka/pull/3815

    KAFKA-5846; Used Singleton NoOpConsumerRebalanceListener in the Kafka…

    …Consumer#subscribe call.
    
    - I haven't removed the internal class 'NoOpConsumerRebalanceListener', as 
it might conflict with the existing users who's using it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Kamal15/kafka rebalance_listener

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3815.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3815
    
----
commit 0af02d35e667948198574fc2c1404c8f340bba1f
Author: Kamal Chandraprakash <kamal.chandraprak...@gmail.com>
Date:   2017-09-08T12:31:58Z

    KAFKA-5846; Used Singleton NoOpConsumerRebalanceListener in the 
KafkaConsumer#subscribe call.

----


> Use singleton NoOpConsumerRebalanceListener in subscribe() call where 
> listener is not specified
> -----------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5846
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5846
>             Project: Kafka
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Kamal Chandraprakash
>            Priority: Minor
>
> Currently KafkaConsumer creates instance of NoOpConsumerRebalanceListener for 
> each subscribe() call where ConsumerRebalanceListener is not specified:
> {code}
>     public void subscribe(Pattern pattern) {
>         subscribe(pattern, new NoOpConsumerRebalanceListener());
> {code}
> We can create a singleton NoOpConsumerRebalanceListener to be used in such 
> scenarios.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)