[
https://issues.apache.org/jira/browse/KAFKA-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166456#comment-16166456
]
Randall Hauch commented on KAFKA-5892:
--------------------------------------
At first blush, it seems like Connect should be able to do something smarter,
like allow the user to override just some of the properties. Technically this
is possible, but this is only really possible if the connector wants to reuse
the same converter defined by the worker. What about when the worker is using
the Avro converter, and a connector sets just one of the JSON converter's
properties? Even if they start out the same and a connector with an override is
deployed, changing the worker configuration to use a different converter will
then result in the connector failing upon restart.
I do agree that Connect should do a better job of warning when a connector
defines just partial converters. For example, if one or more
{{[key|value].converter.*}} properties is specified without the corresponding
{{[key|value].converter}}, we could log an warning or consider this a
configuration error.
The more I think about it, the more I think this is a configuration error.
Thoughts?
> Connector property override does not work unless setting ALL converter
> properties
> ---------------------------------------------------------------------------------
>
> Key: KAFKA-5892
> URL: https://issues.apache.org/jira/browse/KAFKA-5892
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
> Reporter: Yeva Byzek
> Priority: Minor
>
> A single connector setting override {{value.converter.schemas.enable=false}}
> only takes effect if ALL of the converter properties are overridden in the
> connector.
> At minimum, we should give user warning or error that this is will be ignored.
> We should also consider changing the behavior to allow the single property
> override even if all the converter properties are not specified, but this
> requires discussion to evaluate the impact of this change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
