[
https://issues.apache.org/jira/browse/KAFKA-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167241#comment-16167241
]
ASF GitHub Bot commented on KAFKA-5874:
---------------------------------------
GitHub user huxihx opened a pull request:
https://github.com/apache/kafka/pull/3866
KAFKA-5874: TopicCommand should check at least one parameter is given...
When altering topics, TopicCommand should ensure that at least one of
parameters in `partitions`, `config` or `delete-config` must be specified.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huxihx/kafka KAFKA-5874
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3866.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3866
----
commit 33bfbc741aeff38bfc5956df5a8cf8c9bcf51038
Author: huxihx <huxi...@hotmail.com>
Date: 2017-09-15T02:13:33Z
KAFKA-5874: TopicCommand should check at least one parameter is specified
when altering topics
----
> Incorrect command line handling
> -------------------------------
>
> Key: KAFKA-5874
> URL: https://issues.apache.org/jira/browse/KAFKA-5874
> Project: Kafka
> Issue Type: Bug
> Components: admin
> Affects Versions: 0.10.2.0, 0.11.0.0
> Environment: Probably unrelated, but Windows 10 in this case
> Reporter: Viliam Durina
> Priority: Minor
>
> Extra parameters on command line are silently ignored. This leads to
> confusion. For example, I did this command:
> {{kafka-topics.bat --alter --topic my_topic partitions 3 --zookeeper
> localhost}}
> Seemingly innocuous command took about 3 seconds and output nothing. It took
> me a while to realize I missed "--" before "partitions", after which I got a
> confirmation on output.
> Erroneous command lines should produce error output.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
