[
https://issues.apache.org/jira/browse/KAFKA-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168769#comment-16168769
]
ASF GitHub Bot commented on KAFKA-5915:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/3879
KAFKA-5915: Support unmapping of mapped/direct buffers in Java 9
As mentioned in MappedByteBuffers' class documentation, its
implementation was inspired by Lucene's MMapDirectory:
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.6.1/lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java#L315
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-5915-unmap-mapped-buffers-java-9
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3879.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3879
----
commit e168f970ed726524b1d7f6ec70dfb4bfff8da754
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-09-16T02:05:50Z
KAFKA-5915: Support unmapping of mapped/direct buffers in Java 9
----
> Support unmapping of mapped/direct buffers in Java 9
> ----------------------------------------------------
>
> Key: KAFKA-5915
> URL: https://issues.apache.org/jira/browse/KAFKA-5915
> Project: Kafka
> Issue Type: Improvement
> Reporter: Ismael Juma
> Assignee: Ismael Juma
> Fix For: 1.0.0
>
>
> This currently fails with:
> {code}
> java.lang.IllegalAccessError: class kafka.log.AbstractIndex (in unnamed
> module @0x45103d6b) cannot access class jdk.internal.ref.Cleaner (in module
> java.base) because module java.base does not export jdk.internal.ref to
> unnamed module @0x45103d6b
> {code}
> A commit that shows how Lucene changed their code to run without warnings:
> https://github.com/apache/lucene-solr/commit/7e03427fa14a024ce257babcb8362d2451941e21
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
