[
https://issues.apache.org/jira/browse/KAFKA-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172519#comment-16172519
]
ASF GitHub Bot commented on KAFKA-5937:
---------------------------------------
GitHub user mjsax opened a pull request:
https://github.com/apache/kafka/pull/3913
KAFKA-5937: Improve ProcessorStateManager exception handling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/kafka
kafka-5937-exceptions-processor-state-manager
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3913.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3913
----
commit 308e1744df9c51c888e47e759a0e80792a98f249
Author: Matthias J. Sax <matth...@confluent.io>
Date: 2017-09-20T00:02:11Z
KAFKA-5937: Improve ProcessorStateManager exception handling
----
> Improve ProcessorStateManager exception handling
> ------------------------------------------------
>
> Key: KAFKA-5937
> URL: https://issues.apache.org/jira/browse/KAFKA-5937
> Project: Kafka
> Issue Type: Sub-task
> Components: streams
> Affects Versions: 0.11.0.0, 0.11.0.1
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Fix For: 1.0.0
>
>
> We identified the follow issues:
> - constructor calls {{StateDirectory#directoryForTask() }} and wraps throw
> ProcessorStateException with LockException and rethrows -> we should not
> change the exception type here
> - {{ProcessorStateManager#flush()}} loops through all stores and calls
> {{StateStore#flush()}}; it stops on first {{Exception}} -> we should keep
> looping and flush all remaining stores before rethrowing at the end
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
