[ 
https://issues.apache.org/jira/browse/KAFKA-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175253#comment-16175253
 ] 

ASF GitHub Bot commented on KAFKA-5956:
---------------------------------------

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/3936

    KAFKA-5956: use serdes from materialized in table and globalTable

    The new overloads `StreamBuilder.table(String, Materialized)` and 
`StreamsBuilder.globalTable(String, Materialized)` need to set the serdes from 
`Materialized` on the internal `Consumed` instance that is created, otherwise 
the defaults will be used and may result in serialization errors

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka table-materialized

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3936.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3936
    
----
commit a9dac7ef6499312d7e2a333fee80f3363c9f573b
Author: Damian Guy <damian....@gmail.com>
Date:   2017-09-21T18:16:52Z

    use serdes from materialized in table and globaltable

----


> StreamBuilder#table and StreamsBuilder#globalTable should use serdes from 
> Materialized
> --------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5956
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5956
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Damian Guy
>            Assignee: Damian Guy
>             Fix For: 1.0.0
>
>
> The new overloads {{StreamBuilder.table(String, Materialized)}} and 
> {{StreamsBuilder.globalTable(String, Materialized)}} need to set the serdes 
> from {{Materialized}} on the internal {{Consumed}} instance that is created, 
> otherwise the defaults will be used and may result in serialization errors



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to