[ https://issues.apache.org/jira/browse/KAFKA-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175471#comment-16175471 ]
ASF GitHub Bot commented on KAFKA-5949: --------------------------------------- GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/3939 KAFKA-5949: User Callback Exceptions need to be handled properly - catch user exception in user callback (TimestampExtractor, DeserializationHandler, StateRestoreListener) and wrap with StreamsException Additional cleanup: - rename globalRestoreListener to userRestoreListener - remove unnecessary interface -> collapse SourceNodeRecordDeserializer and RecordDeserializer - removed unused parameter loggingEnabled from ProcessorContext#register You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax/kafka kafka-5949-exceptions-user-callbacks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3939.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3939 ---- commit 0dbfeb64781de1a65a1d5f2c0567f6035c49e2ce Author: Matthias J. Sax <matth...@confluent.io> Date: 2017-09-21T21:10:26Z KAFKA-5949: User Callback Exceptions need to be handled properly ---- > User Callback Exceptions need to be handled properly > ---------------------------------------------------- > > Key: KAFKA-5949 > URL: https://issues.apache.org/jira/browse/KAFKA-5949 > Project: Kafka > Issue Type: Sub-task > Components: streams > Reporter: Matthias J. Sax > Assignee: Matthias J. Sax > Fix For: 1.0.0 > > > In Streams, we allow to register multiple user callbacks. We need to handle > those exceptions gracefully, by catching and wrapping with a StreamsException. > - TimestampExtractor > - DeserializationHandler > - StateRestoreListener -- This message was sent by Atlassian JIRA (v6.4.14#64029)