[ https://issues.apache.org/jira/browse/KAFKA-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185235#comment-16185235 ]
ASF GitHub Bot commented on KAFKA-5746: --------------------------------------- GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3989 KAFKA-5746; Fix conversion count computed in `downConvert` It should be the number of records instead of the number of batches. A few additional clean-ups: minor renames, removal of unused code, test fixes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-5746-health-metrics-follow-up Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3989.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3989 ---- commit a85feb150a4aea8d879535c27ddb857278790e63 Author: Ismael Juma <ism...@juma.me.uk> Date: 2017-09-29T01:40:29Z KAFKA-5746; Fix downConvert's conversion count It should be the number of records instead of the number of batches. A few additional clean-ups: minor renames, removal of unused code, test fixes. ---- > Add new metrics to support health checks > ---------------------------------------- > > Key: KAFKA-5746 > URL: https://issues.apache.org/jira/browse/KAFKA-5746 > Project: Kafka > Issue Type: New Feature > Components: metrics > Reporter: Rajini Sivaram > Assignee: Rajini Sivaram > Fix For: 1.0.0 > > > It will be useful to have some additional metrics to support health checks. > Details are in > [KIP-188|https://cwiki.apache.org/confluence/display/KAFKA/KIP-188+-+Add+new+metrics+to+support+health+checks] -- This message was sent by Atlassian JIRA (v6.4.14#64029)