[ 
https://issues.apache.org/jira/browse/KAFKA-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187683#comment-16187683
 ] 

Matthias J. Sax commented on KAFKA-5988:
----------------------------------------

[~sssanthalingam] [~tedyu] Thinking about this, I am not sure if we should 
apply this change. While the JIRA makes sense for the current code base, we 
want to consider dynamic scaling of thread within a single {{KafkaStreams}} 
instance, and thus, keeping the atomic counter would be "future proof" as it 
allow us to assign new unique IDs to thread we start later. A local variable 
within {{KafakStreams}} constructor would not help for this case. \cc 
[~guozhang] [~damianguy] [~bbejeck]

> Consider removing StreamThread#STREAM_THREAD_ID_SEQUENCE
> --------------------------------------------------------
>
>                 Key: KAFKA-5988
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5988
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: siva santhalingam
>            Priority: Minor
>
> StreamThread#STREAM_THREAD_ID_SEQUENCE is used for naming (numbering) 
> StreamThread's .
> It is used in create() which is called from a loop in KafkaStreams ctor.
> We can remove STREAM_THREAD_ID_SEQUENCE and pass the loop index to create()



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to