[ 
https://issues.apache.org/jira/browse/KAFKA-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197487#comment-16197487
 ] 

ASF GitHub Bot commented on KAFKA-5541:
---------------------------------------

GitHub user mjsax opened a pull request:

    https://github.com/apache/kafka/pull/4046

    KAFKA-5541: minor follow-up

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mjsax/kafka kafka-5541-minor-follow-up

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4046.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4046
    
----
commit 5c243d7b9d7e07200e2b5624d621787207699f79
Author: Matthias J. Sax <matth...@confluent.io>
Date:   2017-10-09T18:45:23Z

    KAFKA-5541: minor follow-up

----


> Streams should not re-throw if suspending/closing tasks fails
> -------------------------------------------------------------
>
>                 Key: KAFKA-5541
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5541
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>             Fix For: 1.1.0
>
>
> Currently, if Stream suspends a task on rebalance or closes a suspended task 
> that got revoked, it re-throws any exception that might occur and the thread 
> dies. However, this in not really necessary as the task was suspended/closed 
> anyway and we can just clean up the task and carry on with the rebalance.
> (cf comments https://github.com/apache/kafka/pull/3449#discussion_r124437816)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to