[
https://issues.apache.org/jira/browse/KAFKA-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219891#comment-16219891
]
Kevin Lu edited comment on KAFKA-5991 at 10/26/17 3:15 AM:
-----------------------------------------------------------
It seems like we can keep the sensor name as it currently is since we need to
identify which TopicPartition a sensor is linked to.
Each lag sensor has three associated {{MetricName}} objects (value, max, and
average). When we register these, we can set the name to {{records-lag}},
{{records-lag-max}}, and {{records-lag-avg}}. We can put the
{{TopicPartition_ID}} in the tags with key as {{topicPartition}}.
Since {{MetricName}} object does equality based on {{group}}, {{name}}, and
{{tags}}, we won't have any conflict issues.
was (Author: lu.kevin):
It seems like we can keep the sensor name as it currently is since we need to
identify which TopicPartition a sensor is linked to.
Each lag sensor has three associated {{MetricName}} objects (value, max, and
average). When we register these, we can set the name to {{records-lag}},
{{records-lag-max}}, and {{records-lag-avg}}. We can put the
{{TopicPartition_ID}} in the tags with key as {{topicPartition}}.
Since {{MetricName}} object does equality based on {{group}}, {{name}}, and
{{tags}}, we'll be able to achieve uniqueness still.
> Change Consumer per partition lag metrics to put topic-partition-id in tags
> instead of metric name
> --------------------------------------------------------------------------------------------------
>
> Key: KAFKA-5991
> URL: https://issues.apache.org/jira/browse/KAFKA-5991
> Project: Kafka
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 0.10.0.0, 0.10.0.1, 0.10.1.0, 0.10.2.0, 0.11.0.0
> Reporter: Kevin Lu
> Priority: Minor
> Labels: metrics
>
> [KIP-92|https://cwiki.apache.org/confluence/display/KAFKA/KIP-92+-+Add+per+partition+lag+metrics+to+KafkaConsumer]
> brought per partition lag metrics to {{KafkaConsumer}}, but these metrics
> put the {{TOPIC-PARTITION_ID}} inside of the metric name itself. These
> metrics should instead utilize the tags and put {{key="topic-partition"}} and
> {{value=TOPIC-PARTITION_ID}}.
> Per-broker (node) and per-topic metrics utilize tags in this way by putting
> {{key="node/topic"}} and {{value=NODE_ID/TOPIC_NAME}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
