[ https://issues.apache.org/jira/browse/KAFKA-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222537#comment-16222537 ]
ASF GitHub Bot commented on KAFKA-4928: --------------------------------------- GitHub user Sammers21 opened a pull request: https://github.com/apache/kafka/pull/4145 KAFKA-4928: Add integration test for DumpLogSegments Adding tests for `kafka.tools.DumpLogSegments` You can merge this pull request into a Git repository by running: $ git pull https://github.com/Sammers21/kafka test_for_dump_log_segments Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4145.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4145 ---- ---- > Add integration test for DumpLogSegments > ---------------------------------------- > > Key: KAFKA-4928 > URL: https://issues.apache.org/jira/browse/KAFKA-4928 > Project: Kafka > Issue Type: Test > Reporter: Ismael Juma > Labels: newbie > Fix For: 1.1.0 > > > DumpLogSegments is an important tool to analyse log files, but we have no > JUnit tests for it. It would be good to have some tests that verify that the > output is sane for a populated log. > Our system tests call DumpLogSegments, but we should be able to detect > regressions via the JUnit test suite. -- This message was sent by Atlassian JIRA (v6.4.14#64029)