[
https://issues.apache.org/jira/browse/KAFKA-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247803#comment-16247803
]
ASF GitHub Bot commented on KAFKA-5238:
---------------------------------------
GitHub user edoardocomar opened a pull request:
https://github.com/apache/kafka/pull/4204
KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted
Avoiding a DelayedFetch recreate the metrics when a topic has been
deleted
developed with @mimaison
added unit test borrowed from @ijuma JIRA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/edoardocomar/kafka KAFKA-5238
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4204
----
commit 4e0cee4c81d8bc85ca35d59b927d797330234aab
Author: Edoardo Comar <[email protected]>
Date: 2017-11-10T17:09:18Z
KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted
Avoiding a DelayedFetch recreate the metrics when a topic has been
deleted
developed with @mimaison
----
> BrokerTopicMetrics can be recreated after topic is deleted
> ----------------------------------------------------------
>
> Key: KAFKA-5238
> URL: https://issues.apache.org/jira/browse/KAFKA-5238
> Project: Kafka
> Issue Type: Bug
> Reporter: Ismael Juma
> Assignee: Edoardo Comar
>
> As part of KAFKA-3258, we added code to remove metrics during topic deletion.
> This works fine as long as there are no fetch requests in the purgatory. If
> there are, however, we'll recreate the metrics when we call
> `ReplicaManager.appendToLocalLog`.
> This can be reproduced by updating
> MetricsTest.testBrokerTopicMetricsUnregisteredAfterDeletingTopic() in the
> following way:
> {code}
> @Test
> def testBrokerTopicMetricsUnregisteredAfterDeletingTopic() {
> val topic = "test-broker-topic-metric"
> AdminUtils.createTopic(zkUtils, topic, 2, 1)
> // Produce a few messages and consume them to create the metrics
> TestUtils.produceMessages(servers, topic, nMessages)
> TestUtils.consumeTopicRecords(servers, topic, nMessages)
> assertTrue("Topic metrics don't exist", topicMetricGroups(topic).nonEmpty)
> assertNotNull(BrokerTopicStats.getBrokerTopicStats(topic))
> AdminUtils.deleteTopic(zkUtils, topic)
> TestUtils.verifyTopicDeletion(zkUtils, topic, 1, servers)
> Thread.sleep(10000)
> assertEquals("Topic metrics exists after deleteTopic", Set.empty,
> topicMetricGroups(topic))
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
