[jira] [Comment Edited] (KAFKA-5802) ScramServerCallbackHandler#handle should check username not being null before calling credentialCache.get()

[Ted Yu (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KAFKA-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212069#comment-16212069
 ] 

Ted Yu edited comment on KAFKA-5802 at 11/18/17 12:43 AM:
----------------------------------------------------------

Thanks for the PR, Umesh .


was (Author: yuzhih...@gmail.com):
Thanks for the PR, Umesh.

> ScramServerCallbackHandler#handle should check username not being null before 
> calling credentialCache.get()
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5802
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5802
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>         String username = null;
>         for (Callback callback : callbacks) {
>             if (callback instanceof NameCallback)
>                 username = ((NameCallback) callback).getDefaultName();
>             else if (callback instanceof ScramCredentialCallback)
>                 ((ScramCredentialCallback) 
> callback).scramCredential(credentialCache.get(username));
> {code}
> Since ConcurrentHashMap, used by CredentialCache, doesn't allow null keys, we 
> should check that username is not null before calling credentialCache.get()



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)