[
https://issues.apache.org/jira/browse/KAFKA-6313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280289#comment-16280289
]
ASF GitHub Bot commented on KAFKA-6313:
---------------------------------------
GitHub user rhauch opened a pull request:
https://github.com/apache/kafka/pull/4296
KAFKA-6313: Add SLF4J as direct dependency to Kafka core
Recent changes are now directly using the SLF4J API, so we should have a
direct dependency.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rhauch/kafka kafka-6313
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4296
----
commit eb38ce67d82a47f932ab8cf6b39b05e5887f5300
Author: Randall Hauch <rha...@gmail.com>
Date: 2017-12-06T15:07:45Z
KAFKA-6313: Add SLF4J as direct dependency to Kafka core
----
> Kafka Core maven dependencies are missing SLF4J API
> ---------------------------------------------------
>
> Key: KAFKA-6313
> URL: https://issues.apache.org/jira/browse/KAFKA-6313
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 1.1.0
> Reporter: Randall Hauch
> Assignee: Ismael Juma
> Fix For: 1.1.0
>
>
> In an application that depends on the Kafka server artifacts with:
> {code:xml}
> <dependency>
> <groupId>org.apache.kafka</groupId>
> <artifactId>kafka_2.11</artifactId>
> <version>1.1.0-SNAPSHOT</version>
> </dependency>
> {code}
> and then running the server programmatically, the following error occurs:
> {noformat}
> [2017-11-23 01:01:45,029] INFO Shutting down producer
> (kafka.producer.Producer:63)
> [2017-11-23 01:01:45,051] INFO Closing all sync producers
> (kafka.producer.ProducerPool:63)
> [2017-11-23 01:01:45,052] INFO Producer shutdown completed in 23 ms
> (kafka.producer.Producer:63)
> [2017-11-23 01:01:45,052] INFO [KafkaServer id=1] shutting down
> (kafka.server.KafkaServer:63)
> [2017-11-23 01:01:45,057] ERROR [KafkaServer id=1] Fatal error during
> KafkaServer shutdown. (kafka.server.KafkaServer:161)
> java.lang.NoClassDefFoundError: org/slf4j/event/Level
> at kafka.utils.CoreUtils$.swallow$default$3(CoreUtils.scala:83)
> at kafka.server.KafkaServer.shutdown(KafkaServer.scala:520)
> ...
> Caused by: java.lang.ClassNotFoundException: org.slf4j.event.Level
> at java.net.URLClassLoader$1.run(URLClassLoader.java:359)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:348)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:347)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:312)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
> ... 25 more
> {noformat}
> It appears that KAFKA-1044 and [this
> PR|https://github.com/apache/kafka/pull/3477] removed the use of Log4J from
> Core but [added use
> of|https://github.com/confluentinc/kafka/commit/ed8b0315a6c3705b2a163ce3ab4723234779264f#diff-52505b9374ea885e44bcb73cbc4714d6R34]
> the {{org.slf4j.event.Level}} in {{CoreUtils.scala}}. The
> {{org.slf4j.event.Level}} class is in the {{org.slf4j:slf4j-api}} artifact,
> which is currently not included in the dependencies of
> {{org.apache.kafka:kafka_2.11:1.1.0-SNAPSHOT}}. Because this is needed by the
> server, the SLF4J API library probably needs to be added to the dependencies.
> [~viktorsomogyi] and [~ijuma], was this intentional, or is it intended that
> the SLF4J API be marked as {{provided}}? BTW, I marked this as CRITICAL just
> because this probably needs to be sorted out before the release.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
