[
https://issues.apache.org/jira/browse/KAFKA-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283003#comment-16283003
]
ASF GitHub Bot commented on KAFKA-6323:
---------------------------------------
GitHub user fredfp opened a pull request:
https://github.com/apache/kafka/pull/4304
KAFKA-6323: document that punctuation is called immediately.
If KAFKA-6323 is not a bug, then it needs better documentation.
Alternative to https://github.com/apache/kafka/pull/4301
@mihbor @mjsax
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fredfp/kafka KAFKA-6323
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4304
----
commit 935d0fc61084f383ec528d28f9c18f8b51fff1d2
Author: Frederic Arno <frederica...@gmail.com>
Date: 2017-12-08T03:22:52Z
KAFKA-6323: document that punctuation is called immediately.
----
> punctuate with WALL_CLOCK_TIME triggered immediately
> ----------------------------------------------------
>
> Key: KAFKA-6323
> URL: https://issues.apache.org/jira/browse/KAFKA-6323
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 1.0.0
> Reporter: Frederic Arno
> Fix For: 1.1.0, 1.0.1
>
>
> When working on a custom Processor from which I am scheduling a punctuation
> using WALL_CLOCK_TIME. I've noticed that whatever the punctuation interval I
> set, a call to my Punctuator is always triggered immediately.
> Having a quick look at kafka-streams' code, I could find that all
> PunctuationSchedule's timestamps are matched against the current time in
> order to decide whether or not to trigger the punctuator
> (org.apache.kafka.streams.processor.internals.PunctuationQueue#mayPunctuate).
> However, I've only seen code that initializes PunctuationSchedule's timestamp
> to 0, which I guess is what is causing an immediate punctuation.
> At least when using WALL_CLOCK_TIME, shouldn't the PunctuationSchedule's
> timestamp be initialized to current time + interval?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
