[
https://issues.apache.org/jira/browse/KAFKA-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284053#comment-16284053
]
ASF GitHub Bot commented on KAFKA-6307:
---------------------------------------
GitHub user tedyu opened a pull request:
https://github.com/apache/kafka/pull/4307
KAFKA-6307 mBeanName should be removed before returning from
JmxReporter#removeAttribute()
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4307
----
commit 82d3f60eaf0548b478c7d873c5fbf4b930a11473
Author: tedyu <[email protected]>
Date: 2017-12-08T19:08:30Z
KAFKA-6307 mBeanName should be removed before returning from
JmxReporter#removeAttribute()
----
> mBeanName should be removed before returning from
> JmxReporter#removeAttribute()
> -------------------------------------------------------------------------------
>
> Key: KAFKA-6307
> URL: https://issues.apache.org/jira/browse/KAFKA-6307
> Project: Kafka
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: siva santhalingam
>
> JmxReporter$KafkaMbean showed up near the top in the first histo output from
> KAFKA-6199.
> In JmxReporter#removeAttribute() :
> {code}
> KafkaMbean mbean = this.mbeans.get(mBeanName);
> if (mbean != null)
> mbean.removeAttribute(metricName.name());
> return mbean;
> {code}
> mbeans.remove(mBeanName) should be called before returning.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
