[
https://issues.apache.org/jira/browse/KAFKA-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289550#comment-16289550
]
Ted Yu commented on KAFKA-6335:
-------------------------------
SimpleAclAuthorizer#updateResourceAcls() returns boolean, indicating whether
the update succeeds or not.
However, the return value is not checked by
testHighConcurrencyModificationOfResourceAcls().
In highly contended scenario, the test should expect few of the Acl request not
going thru.
> SimpleAclAuthorizerTest#testHighConcurrencyModificationOfResourceAcls fails
> intermittently
> ------------------------------------------------------------------------------------------
>
> Key: KAFKA-6335
> URL: https://issues.apache.org/jira/browse/KAFKA-6335
> Project: Kafka
> Issue Type: Test
> Reporter: Ted Yu
> Assignee: Manikumar
> Fix For: 1.1.0
>
>
> From
> https://builds.apache.org/job/kafka-pr-jdk9-scala2.12/3045/testReport/junit/kafka.security.auth/SimpleAclAuthorizerTest/testHighConcurrencyModificationOfResourceAcls/
> :
> {code}
> java.lang.AssertionError: expected acls Set(User:36 has Allow permission for
> operations: Read from hosts: *, User:7 has Allow permission for operations:
> Read from hosts: *, User:21 has Allow permission for operations: Read from
> hosts: *, User:39 has Allow permission for operations: Read from hosts: *,
> User:43 has Allow permission for operations: Read from hosts: *, User:3 has
> Allow permission for operations: Read from hosts: *, User:35 has Allow
> permission for operations: Read from hosts: *, User:15 has Allow permission
> for operations: Read from hosts: *, User:16 has Allow permission for
> operations: Read from hosts: *, User:22 has Allow permission for operations:
> Read from hosts: *, User:26 has Allow permission for operations: Read from
> hosts: *, User:11 has Allow permission for operations: Read from hosts: *,
> User:38 has Allow permission for operations: Read from hosts: *, User:8 has
> Allow permission for operations: Read from hosts: *, User:28 has Allow
> permission for operations: Read from hosts: *, User:32 has Allow permission
> for operations: Read from hosts: *, User:25 has Allow permission for
> operations: Read from hosts: *, User:41 has Allow permission for operations:
> Read from hosts: *, User:44 has Allow permission for operations: Read from
> hosts: *, User:48 has Allow permission for operations: Read from hosts: *,
> User:2 has Allow permission for operations: Read from hosts: *, User:9 has
> Allow permission for operations: Read from hosts: *, User:14 has Allow
> permission for operations: Read from hosts: *, User:46 has Allow permission
> for operations: Read from hosts: *, User:13 has Allow permission for
> operations: Read from hosts: *, User:5 has Allow permission for operations:
> Read from hosts: *, User:29 has Allow permission for operations: Read from
> hosts: *, User:45 has Allow permission for operations: Read from hosts: *,
> User:6 has Allow permission for operations: Read from hosts: *, User:37 has
> Allow permission for operations: Read from hosts: *, User:23 has Allow
> permission for operations: Read from hosts: *, User:19 has Allow permission
> for operations: Read from hosts: *, User:24 has Allow permission for
> operations: Read from hosts: *, User:17 has Allow permission for operations:
> Read from hosts: *, User:34 has Allow permission for operations: Read from
> hosts: *, User:12 has Allow permission for operations: Read from hosts: *,
> User:42 has Allow permission for operations: Read from hosts: *, User:4 has
> Allow permission for operations: Read from hosts: *, User:47 has Allow
> permission for operations: Read from hosts: *, User:18 has Allow permission
> for operations: Read from hosts: *, User:31 has Allow permission for
> operations: Read from hosts: *, User:49 has Allow permission for operations:
> Read from hosts: *, User:33 has Allow permission for operations: Read from
> hosts: *, User:1 has Allow permission for operations: Read from hosts: *,
> User:27 has Allow permission for operations: Read from hosts: *) but got
> Set(User:36 has Allow permission for operations: Read from hosts: *, User:7
> has Allow permission for operations: Read from hosts: *, User:21 has Allow
> permission for operations: Read from hosts: *, User:39 has Allow permission
> for operations: Read from hosts: *, User:43 has Allow permission for
> operations: Read from hosts: *, User:3 has Allow permission for operations:
> Read from hosts: *, User:35 has Allow permission for operations: Read from
> hosts: *, User:15 has Allow permission for operations: Read from hosts: *,
> User:16 has Allow permission for operations: Read from hosts: *, User:22 has
> Allow permission for operations: Read from hosts: *, User:26 has Allow
> permission for operations: Read from hosts: *, User:11 has Allow permission
> for operations: Read from hosts: *, User:38 has Allow permission for
> operations: Read from hosts: *, User:8 has Allow permission for operations:
> Read from hosts: *, User:28 has Allow permission for operations: Read from
> hosts: *, User:32 has Allow permission for operations: Read from hosts: *,
> User:25 has Allow permission for operations: Read from hosts: *, User:41 has
> Allow permission for operations: Read from hosts: *, User:44 has Allow
> permission for operations: Read from hosts: *, User:48 has Allow permission
> for operations: Read from hosts: *, User:2 has Allow permission for
> operations: Read from hosts: *, User:9 has Allow permission for operations:
> Read from hosts: *, User:14 has Allow permission for operations: Read from
> hosts: *, User:46 has Allow permission for operations: Read from hosts: *,
> User:13 has Allow permission for operations: Read from hosts: *, User:5 has
> Allow permission for operations: Read from hosts: *, User:29 has Allow
> permission for operations: Read from hosts: *, User:45 has Allow permission
> for operations: Read from hosts: *, User:6 has Allow permission for
> operations: Read from hosts: *, User:37 has Allow permission for operations:
> Read from hosts: *, User:23 has Allow permission for operations: Read from
> hosts: *, User:19 has Allow permission for operations: Read from hosts: *,
> User:24 has Allow permission for operations: Read from hosts: *, User:17 has
> Allow permission for operations: Read from hosts: *, User:34 has Allow
> permission for operations: Read from hosts: *, User:12 has Allow permission
> for operations: Read from hosts: *, User:42 has Allow permission for
> operations: Read from hosts: *, User:4 has Allow permission for operations:
> Read from hosts: *, User:47 has Allow permission for operations: Read from
> hosts: *, User:18 has Allow permission for operations: Read from hosts: *,
> User:31 has Allow permission for operations: Read from hosts: *, User:49 has
> Allow permission for operations: Read from hosts: *, User:33 has Allow
> permission for operations: Read from hosts: *, User:27 has Allow permission
> for operations: Read from hosts: *)
> {code}
> After initial check, one user in the expected Set() was missing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
