[
https://issues.apache.org/jira/browse/KAFKA-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301518#comment-16301518
]
ASF GitHub Bot commented on KAFKA-6321:
---------------------------------------
becketqin commented on a change in pull request #4344: KAFKA-6321: Consolidate
calls to KafkaConsumer's `beginningOffsets()` and `endOffsets()` in
ConsumerGroupCommand
URL: https://github.com/apache/kafka/pull/4344#discussion_r158502909
##########
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##########
@@ -274,7 +274,10 @@ object ConsumerGroupCommand extends Logging {
protected def opts: ConsumerGroupCommandOptions
- protected def getLogEndOffset(topicPartition: TopicPartition):
LogOffsetResult
+ protected def getLogEndOffset(topicPartition: TopicPartition):
LogOffsetResult =
+
getLogEndOffsets(Seq(topicPartition)).get(topicPartition).getOrElse(LogOffsetResult.Ignore)
Review comment:
Could just be
```getLogEndOffsets(Seq(topicPartition)).getOrElse(topicPartition,
LogOffsetResult.Ignore)```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ConsumerGroupCommand should use the new consumer to query the log end offsets.
> ------------------------------------------------------------------------------
>
> Key: KAFKA-6321
> URL: https://issues.apache.org/jira/browse/KAFKA-6321
> Project: Kafka
> Issue Type: Improvement
> Components: tools
> Affects Versions: 1.0.0
> Reporter: Jiangjie Qin
> Assignee: Vahid Hashemian
> Fix For: 1.1.0
>
>
> Currently the ConsumerGroupCommand is querying the log end offsets one
> partition at a time. It should switch to use Consumer.endOffsets().
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
