[
https://issues.apache.org/jira/browse/KAFKA-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328196#comment-16328196
]
ASF GitHub Bot commented on KAFKA-6138:
---------------------------------------
panuwat-sc opened a new pull request #4430: KAFKA-6138 Simplify
StreamsBuilder#addGlobalStore
URL: https://github.com/apache/kafka/pull/4430
deprecated StreamsBuilder#addGlobalStore and
InternalStreamsBuilder#addGlobalStore
add new StreamsBuilder#addGlobalStore and
InternalStreamsBuilder#addGlobalStore without sourceName and processorName as
parameter
generate sourceName and processorName by using
InternalStreamsBuilder#newProcessorName
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify StreamsBuilder#addGlobalStore
> --------------------------------------
>
> Key: KAFKA-6138
> URL: https://issues.apache.org/jira/browse/KAFKA-6138
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 1.0.0
> Reporter: Matthias J. Sax
> Assignee: Panuwat Anawatmongkhon
> Priority: Major
> Labels: beginner, kip, newbie
>
> {{StreamsBuilder#addGlobalStore}} is conceptually a 1:1 copy of
> {{Topology#addGlobalStore}}, that would follow DSL design principles though.
> Atm, {{StreamsBuilder#addGlobalStore}} does not follow provide a good user
> experience as it forces users to specify names for processor names –
> processor name are a Processor API detail should be hidden in the DSL. The
> current API is the following:
> {noformat}
> public synchronized StreamsBuilder addGlobalStore(final StoreBuilder
> storeBuilder,
> final String topic,
> final String sourceName,
> final Consumed consumed,
> final String
> processorName,
> final ProcessorSupplier
> stateUpdateSupplier)
> {noformat}
> We should remove the two parameters {{sourceName}} and {{processorName}}. To
> be backward compatible, the current method must be deprecated and a new
> method should be added with reduced number of parameters.
> KIP:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-233%3A+Simplify+StreamsBuilder%23addGlobalStore
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
