[
https://issues.apache.org/jira/browse/KAFKA-5540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336964#comment-16336964
]
ASF GitHub Bot commented on KAFKA-5540:
---------------------------------------
umesh9794 opened a new pull request #4467: KAFKA-5540 : Deprecate and remove
internal converter configs
URL: https://github.com/apache/kafka/pull/4467
This PR deprecates the following configs:
`internal.key.converter`
`internal.value.converter`
And removes their usage from connect-*.properties files.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate and remove internal converter configs
> -----------------------------------------------
>
> Key: KAFKA-5540
> URL: https://issues.apache.org/jira/browse/KAFKA-5540
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 0.11.0.0
> Reporter: Ewen Cheslack-Postava
> Priority: Major
> Labels: needs-kip
>
> The internal.key.converter and internal.value.converter were original exposed
> as configs because a) they are actually pluggable and b) providing a default
> would require relying on the JsonConverter always being available, which
> until we had classloader isolation it was possible might be removed for
> compatibility reasons.
> However, this has ultimately just caused a lot more trouble and confusion
> than it is worth. We should deprecate the configs, give them a default of
> JsonConverter (which is also kind of nice since it results in human-readable
> data in the internal topics), and then ultimately remove them in the next
> major version.
> These are all public APIs so this will need a small KIP before we can make
> the change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
