ASF GitHub Bot commented on KAFKA-6550:

huxihx opened a new pull request #4553: KAFKA-6550: UpdateMetadataRequest 
should be lazily created
URL: https://github.com/apache/kafka/pull/4553
   We should defer to construct UpdateMetadataRequest Builder to the right time 
when we really need them.
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> UpdateMetadataRequest should be lazily created
> ----------------------------------------------
>                 Key: KAFKA-6550
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6550
>             Project: Kafka
>          Issue Type: Improvement
>          Components: controller
>    Affects Versions: 1.0.0
>            Reporter: huxihx
>            Assignee: huxihx
>            Priority: Minor
> In ControllerBrokerRequestBatch.sendRequestsToBrokers, there is no need to 
> eagerly construct the UpdateMetadataRequest.Builder since sometimes 
> updateMetadataRequestBrokerSet is actually empty. In those cases, we should 
> defer the construction to the time when we really need them.

This message was sent by Atlassian JIRA

Reply via email to