vamossagar12 commented on code in PR #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r887646972
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStoreTest.java:
##########
@@ -178,44 +178,36 @@ public void shouldPutAndFetch() {
try (final KeyValueIterator<Bytes, byte[]> values = bytesStore.fetch(
Bytes.wrap(keyA.getBytes()), 0, windows[2].start())) {
-
- final List<KeyValue<Windowed<String>, Long>> expected = asList(
- KeyValue.pair(new Windowed<>(keyA, windows[0]), 10L),
- KeyValue.pair(new Windowed<>(keyA, windows[1]), 50L)
- );
+ // For all tests, actualFrom is computed using observedStreamTime
- retention + 1.
+ // so actualFrom = 60000(observedStreamTime) - 1000(retention) + 1
= 59001
+ // all records expired as actual from is 59001 and to is 1000
+ final List<KeyValue<Windowed<String>, Long>> expected =
Collections.emptyList();
Review Comment:
The reason I left it like this was that this same test has different fetches
across different time ranges. Some of them don't return anything due to expiry
and some of them do. So, I felt this test captures all those scenarios
properly. Probably at this point, leaving it this way might be ok unless you
have reservations on that idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
