RivenSun2 commented on code in PR #12226:
URL: https://github.com/apache/kafka/pull/12226#discussion_r887935524
##########
clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java:
##########
@@ -69,7 +69,7 @@ public class SslConfigs {
public static final String SSL_KEYSTORE_TYPE_CONFIG = "ssl.keystore.type";
public static final String SSL_KEYSTORE_TYPE_DOC = "The file format of the
key store file. "
- + "This is optional for client.";
+ + "This is optional for client. The currently supported values for
kafka are [JKS , PKCS12, PEM].";
Review Comment:
From the existing documentation, the user does not know what other values to
choose than `JKS`. Unless they read the source code or related
[KIP-651.](https://cwiki.apache.org/confluence/display/KAFKA/KIP-651+-+Support+PEM+format+for+SSL+certificates+and+private+key)
I think adding a supplement to the documentation here to show what values
are supported by default in Kafka can help users better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
