ableegoldman commented on code in PR #12235:
URL: https://github.com/apache/kafka/pull/12235#discussion_r889358327
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java:
##########
@@ -388,6 +401,40 @@ private String nodeSensorPrefix(final String threadId,
final String taskId, fina
+ SENSOR_PREFIX_DELIMITER + SENSOR_NODE_LABEL +
SENSOR_PREFIX_DELIMITER + processorNodeName;
}
+ public Sensor topicLevelSensor(final String threadId,
+ final String taskId,
+ final String processorNodeName,
+ final String topicName,
Review Comment:
I did update it to include the `topic` tag already, but I haven't updated it
yet to clarify that we are introducing these at a new "topic-level" metrics
scope. I'll do that right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
