dengziming commented on code in PR #12245:
URL: https://github.com/apache/kafka/pull/12245#discussion_r890020215
##########
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##########
@@ -189,16 +190,33 @@ Found problem:
@Test
def testDefaultMetadataVersion(): Unit = {
- var namespace = StorageTool.parseArguments(Array("format", "-c",
"config.props", "-t", "XcZZOzUqS4yHOjhMQB6JLQ"))
- var mv = StorageTool.getMetadataVersion(namespace)
+ val namespace = StorageTool.parseArguments(Array("format", "-c",
"config.props", "-t", "XcZZOzUqS4yHOjhMQB6JLQ"))
+ val mv = StorageTool.getMetadataVersion(namespace)
assertEquals(MetadataVersion.latest().featureLevel(), mv.featureLevel(),
"Expected the default metadata.version to be the latest version")
+ }
- namespace = StorageTool.parseArguments(Array("format", "-c",
"config.props",
- "--metadata-version", MetadataVersion.latest().featureLevel().toString,
"-t", "XcZZOzUqS4yHOjhMQB6JLQ"))
- mv = StorageTool.getMetadataVersion(namespace)
- assertEquals(MetadataVersion.latest().featureLevel(), mv.featureLevel(),
- "Expected the default metadata.version to be the latest version")
+ @Test
+ def testMetadataVersionFlags(): Unit = {
+ def parseMetadataVersion(strings: String*): MetadataVersion = {
+ var args = mutable.Seq("format", "-c", "config.props", "-t",
"XcZZOzUqS4yHOjhMQB6JLQ")
+ args ++= strings
+ val namespace = StorageTool.parseArguments(args.toArray)
+ StorageTool.getMetadataVersion(namespace)
+ }
+
+ var mv = parseMetadataVersion("--metadata-version", "1")
+ assertEquals(1, mv.featureLevel())
+
+ mv = parseMetadataVersion("--metadata-version", "3")
+ assertEquals(3, mv.featureLevel())
+
+ assertThrows(classOf[TerseFailure], () =>
parseMetadataVersion("--metadata-version", "3", "--release-version", "3.0"))
+
+ mv = parseMetadataVersion("--release-version", "3.0")
+ assertEquals("3.0", mv.shortVersion())
+ mv = parseMetadataVersion("--release-version", "3.0-IV1")
+ assertEquals(MetadataVersion.IBP_3_0_IV1, mv)
Review Comment:
How about adding a test of the wrong release version here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
