mimaison commented on code in PR #12248:
URL: https://github.com/apache/kafka/pull/12248#discussion_r892499161
##########
clients/src/main/java/org/apache/kafka/common/requests/DescribeLogDirsResponse.java:
##########
@@ -31,6 +31,7 @@
public class DescribeLogDirsResponse extends AbstractResponse {
public static final long INVALID_OFFSET_LAG = -1L;
+ public static final long UNKNOWN_VOLUME_BYTES = -1L;
Review Comment:
The wire protocol does not have nullable integers. So the new fields are
defined to use -1 as the default value in the protocol:
https://github.com/apache/kafka/blob/a73b96a7f6c467b32ca30b93534468fd192eeabe/clients/src/main/resources/common/message/DescribeLogDirsResponse.json#L52-L56
This constant is used to map the value in DescribeLogDirsResponse to an
Optional:
https://github.com/apache/kafka/blob/a73b96a7f6c467b32ca30b93534468fd192eeabe/clients/src/main/java/org/apache/kafka/clients/admin/LogDirDescription.java#L44-L45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
