hachikuji commented on code in PR #12269:
URL: https://github.com/apache/kafka/pull/12269#discussion_r892732326
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -942,7 +943,7 @@ public void handleLeaderChange(LeaderAndEpoch newLeader) {
"at least 1. Got " +
bootstrapMetadata.metadataVersion().featureLevel()));
} else {
metadataVersion =
bootstrapMetadata.metadataVersion();
- future = appendWriteEvent("bootstrapMetadata",
OptionalLong.empty(), () -> {
+ future = prependWriteEvent("bootstrapMetadata", ()
-> {
Review Comment:
Can we add a comment about this?
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -967,6 +968,10 @@ public void handleLeaderChange(LeaderAndEpoch newLeader) {
metadataVersion = featureControl.metadataVersion();
}
+ curClaimEpoch = newEpoch;
Review Comment:
Hmm, why is it necessary to reorder these fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
