dajac commented on code in PR #12181:
URL: https://github.com/apache/kafka/pull/12181#discussion_r893566738
##########
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala:
##########
@@ -855,29 +856,49 @@ class ControllerIntegrationTest extends QuorumTestHarness
{
val assignment = Map(tp.partition -> Seq(otherBroker.config.brokerId,
controllerId))
TestUtils.createTopic(zkClient, tp.topic, partitionReplicaAssignment =
assignment, servers = servers)
- val latch = new CountDownLatch(1)
val controller = getController().kafkaController
-
val leaderIsrAndControllerEpochMap =
zkClient.getTopicPartitionStates(Seq(tp))
val newLeaderAndIsr = leaderIsrAndControllerEpochMap(tp).leaderAndIsr
+ val topicId = controller.controllerContext.topicIds.getOrElse(tp.topic,
Uuid.ZERO_UUID)
Review Comment:
I have added a new test case which covers multiple IBPs and request
versions. Does it cover your point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
