mumrah commented on code in PR #12250:
URL: https://github.com/apache/kafka/pull/12250#discussion_r893597965
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##########
@@ -132,10 +131,7 @@ class BrokerMetadataPublisher(conf: KafkaConfig,
// Publish the new metadata image to the metadata cache.
metadataCache.setImage(newImage)
- val metadataVersionLogMsg = newImage.features().metadataVersion() match {
- case MetadataVersion.UNINITIALIZED => "un-initialized metadata.version"
Review Comment:
The IBP is just used for bootstrapping a metadata version when upgrading
from an older KRaft cluster (see my other comment). Broker and controller
components will assume the minimum KRaft version until we finish loading the
metadata log.
Forwarding should be okay since we don't start accepting external
connections until after we've caught up on metadata in the broker.
https://github.com/apache/kafka/blob/f79528f7530af092d71ad6eb9088d1bc208a29fa/core/src/main/scala/kafka/server/BrokerServer.scala#L450-L452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
