showuon commented on code in PR #12179:
URL: https://github.com/apache/kafka/pull/12179#discussion_r895290288
##########
build.gradle:
##########
@@ -1243,7 +1243,7 @@ project(':clients') {
testImplementation libs.bcpkix
testImplementation libs.junitJupiter
- testImplementation libs.mockitoCore
+ testImplementation libs.mockitoInline
Review Comment:
@acsaki , as @ijuma suggested, would you file another small PR to update the
tests to avoid mocking the static methods? For the
`ChannelBuilders#createPrincipalBuilder`, it looks like we actually don't need
it for these tests, right? (the tests still pass after I removed them)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
