[ 
https://issues.apache.org/jira/browse/KAFKA-6332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368963#comment-16368963
 ] 

ASF GitHub Bot commented on KAFKA-6332:
---------------------------------------

asasvari opened a new pull request #4589: KAFKA-6332: Kafka system tests should 
use nc instead of log grep to d…
URL: https://github.com/apache/kafka/pull/4589
 
 
   …etect start-up
   
   - Extracted a new function (listening) in system test utils module to test 
whether a specified port on a specified node is listening for connections.
   - Refactored system tests to use the new function to test whether a 
particular server is started / listening on a port (instead of grepping for 
lines in server logs). 
   - Specified kdc.port for the MiniKdc server in minikdc.properties so that 
the server does not listen for connections on a "random" port.
   - Fixed a typo in the documentation of the node_is_reachable function in 
utils/util.py
   
   Testing done:
   - Executed the following system tests:
   sanity_checks tests,  simple_consumer_shell_test.py, 
consumer_group_command_test.py, trogdor_test.py, 
zookeeper_security_upgrade_test.py
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kafka system tests should use nc instead of log grep to detect start-up
> -----------------------------------------------------------------------
>
>                 Key: KAFKA-6332
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6332
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Ismael Juma
>            Assignee: Attila Sasvari
>            Priority: Major
>              Labels: newbie
>
> [~ewencp] suggested using nc -z test instead of grepping the logs for a more 
> reliable test. This came up when the system tests were broken by a log 
> improvement change.
> Reference: https://github.com/apache/kafka/pull/3834



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to