divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r897733191
##########
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##########
@@ -34,35 +35,56 @@
*/
public abstract class SampledStat implements MeasurableStat {
- private double initialValue;
+ private final double initialValue;
+ /**
+ * Index of the latest stored sample.
+ */
private int current = 0;
+ /**
+ * Stores the recorded samples in a ring buffer.
Review Comment:
That sounds fair. I have fixed the java doc in the latest revision and
replaced with the following
```
/**
* Stores the recorded samples.
* Note that the previously recorded samples may be overwritten/reset if
they are considered obsolete by the
* {@link Sample#purgeObsoleteSamples} function.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
