[GitHub] [kafka] cadonna commented on a diff in pull request #12279: KAFKA-10199: Commit the restoration progress within StateUpdater

[GitBox]

cadonna commented on code in PR #12279:
URL: https://github.com/apache/kafka/pull/12279#discussion_r899850723


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##########
@@ -286,6 +308,7 @@ public void 
shouldRestoreActiveStatefulTasksAndUpdateStandbyTasks() throws Excep
         stateUpdater.add(task4);
 
         verifyRestoredActiveTasks(task2, task1);
+        verifyCommitTasks(true, task2, task1);

Review Comment:
   What if you move this verification after `verifyUpdatingStandbyTasks()`? Are 
standby tasks still not checkpointed because we do not enforce the checkpoint?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org