franz1981 commented on code in PR #12163:
URL: https://github.com/apache/kafka/pull/12163#discussion_r900164891
##########
clients/src/main/java/org/apache/kafka/common/utils/Checksums.java:
##########
@@ -30,21 +36,74 @@
*/
public final class Checksums {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(Checksums.class);
+ private static final MethodHandle BYTE_BUFFER_UPDATE;
+
+ static {
+ MethodHandle byteBufferUpdate = null;
+ if (Java.IS_JAVA9_COMPATIBLE) {
+ try {
+ byteBufferUpdate =
MethodHandles.publicLookup().findVirtual(Checksum.class, "update",
MethodType.methodType(void.class, ByteBuffer.class));
+ } catch (Throwable t) {
+ LOGGER.warn("Cannot uses
java.util.zip.Checksum::update(ByteBuffer): direct ByteBuffers checksum won't
use optimized platform support", t);
+ }
+ }
+ BYTE_BUFFER_UPDATE = byteBufferUpdate;
+ }
+
private Checksums() {
}
+ /**
+ * Uses {@link Checksum#update} on {@code buffer}'s content, without
modifying its position and limit.<br>
+ * This is semantically equivalent to {@link #update(Checksum, ByteBuffer,
int, int)} with {@code offset = 0}.
+ */
public static void update(Checksum checksum, ByteBuffer buffer, int
length) {
update(checksum, buffer, 0, length);
}
+ /**
+ * Uses {@link Checksum#update} on {@code buffer}'s content, starting from
the given {@code offset}
+ * by the provided {@code length}, without modifying its position and
limit.
+ */
public static void update(Checksum checksum, ByteBuffer buffer, int
offset, int length) {
if (buffer.hasArray()) {
checksum.update(buffer.array(), buffer.position() +
buffer.arrayOffset() + offset, length);
- } else {
- int start = buffer.position() + offset;
- for (int i = start; i < start + length; i++)
- checksum.update(buffer.get(i));
+ return;
+ }
+ if (BYTE_BUFFER_UPDATE != null && buffer.isDirect()) {
Review Comment:
Yep, already there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
