C0urante commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1159770142
Thanks for fixing this @dstelljes! Two thoughts: First, can we add a test for this scenario, ideally one that fails without this change and succeeds with it? Second, you're correct that we only invoke `DistributedHerder::startConnector` without a try/catch guard in one place right now. But that might change in the future and reintroduce a different variant of this bug. There are a few ways that we could try to future-proof this method: - Add a checked exception to the signatures of `ClusterConfigState::connectorConfig` and `ClusterConfigState::taskConfig` that forces callers to handle cases where config providers throw exceptions - Add a try/catch guard to `startConnector` that notifies the passed-in `Callback` of any exceptions caught in the body of the method, instead of throwing those exceptions itself Do you think it's worth pursuing either of these? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
