vamossagar12 commented on code in PR #12307:
URL: https://github.com/apache/kafka/pull/12307#discussion_r901856096
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConnectorTest.java:
##########
@@ -142,11 +174,13 @@ public void testFailureIsFinalState() {
ctx.close();
expectLastCall();
- offsetStorageReader.close();
- expectLastCall();
+ if (connectorType == ConnectorType.SOURCE) {
+ offsetStorageReader.close();
+ expectLastCall();
- offsetStore.stop();
- expectLastCall();
+ offsetStore.stop();
+ expectLastCall();
+ }
Review Comment:
hmm I did see the other repeated sections in the tests but since they are
out of scope for the context of this PR, didn't bring them up. I guess we can
live with these newer repetitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
