[ 
https://issues.apache.org/jira/browse/KAFKA-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372221#comment-16372221
 ] 

ASF GitHub Bot commented on KAFKA-6578:
---------------------------------------

rhauch opened a new pull request #4609: KAFKA-6578: Changed the Connect 
distributed and standalone main method to log all exceptions
URL: https://github.com/apache/kafka/pull/4609
 
 
   Any exception thrown by calls within a `main()` method are not logged unless 
explicitly done so. This change simply adds a try-catch block around most of 
the content of the distributed and standalone `main()` methods.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Connect distributed and standalone worker 'main()' methods should catch and 
> log all exceptions
> ----------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-6578
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6578
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 0.10.0.0
>            Reporter: Randall Hauch
>            Priority: Critical
>
> Currently, the {{main}} methods in {{ConnectDistributed}} and 
> {{ConnectStandalone}} do not catch and log most of the potential exceptions. 
> That means that when such an exception does occur, Java does terminate the 
> process and report it to stderr, but does not log the exception in the log.
> We should add a try block around most of the existing code in the main method 
> to catch any Throwable exception, log it, and either rethrow it or explicitly 
> exit with a non-zero return code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to