vamossagar12 commented on code in PR #12363:
URL: https://github.com/apache/kafka/pull/12363#discussion_r910244367
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java:
##########
@@ -93,8 +93,8 @@ RecordQueue queue() {
final Map<TopicPartition, RecordQueue> partitionQueues,
final Function<TopicPartition, OptionalLong> lagProvider,
final Sensor recordLatenessSensor,
+ final Sensor totalInputBufferBytesSensor,
final Sensor enforcedProcessingSensor,
- final Sensor totalBytesSensor,
Review Comment:
There are a couple of unit tests:
https://github.com/apache/kafka/blob/0924fd3f9f75c446310ed1e97b44bbc3f33c6c31/streams/src/test/java/org/apache/kafka/streams/processor/internals/PartitionGroupTest.java#L780
which try to check pause/resume. I think whats missing- and it's a miss on my
part which I now realise- is an e2e IT. Something like push some data, check
paused partitions and later on test their resumption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
