[GitHub] [kafka] hachikuji commented on a diff in pull request #12305: MINOR: Add __cluster_metadata topic to list of internal topics

[GitBox]

hachikuji commented on code in PR #12305:
URL: https://github.com/apache/kafka/pull/12305#discussion_r912151174


##########
clients/src/main/java/org/apache/kafka/common/internals/Topic.java:
##########
@@ -33,7 +33,7 @@ public class Topic {
     public static final String LEGAL_CHARS = "[a-zA-Z0-9._-]";
 
     private static final Set<String> INTERNAL_TOPICS = 
Collections.unmodifiableSet(
-            Utils.mkSet(GROUP_METADATA_TOPIC_NAME, 
TRANSACTION_STATE_TOPIC_NAME));
+            Utils.mkSet(GROUP_METADATA_TOPIC_NAME, 
TRANSACTION_STATE_TOPIC_NAME, METADATA_TOPIC_NAME));

Review Comment:
   I think the change makes sense. Eventually zk clusters will have to upgrade. 
On the other hand, for pre-existing topics which match the same name, I am not 
sure what we should do. Probably we have to catch that case in the upgrade.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org