[ 
https://issues.apache.org/jira/browse/KAFKA-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333251#comment-16333251
 ] 

Ted Yu edited comment on KAFKA-6303 at 2/24/18 3:27 AM:
--------------------------------------------------------

+1


was (Author: yuzhih...@gmail.com):
lgtm

> Potential lack of synchronization in NioEchoServer#AcceptorThread
> -----------------------------------------------------------------
>
>                 Key: KAFKA-6303
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6303
>             Project: Kafka
>          Issue Type: Bug
>          Components: network
>            Reporter: Ted Yu
>            Assignee: siva santhalingam
>            Priority: Minor
>
> In the run() method:
> {code}
>                                 SocketChannel socketChannel = 
> ((ServerSocketChannel) key.channel()).accept();
>                                 socketChannel.configureBlocking(false);
>                                 newChannels.add(socketChannel);
> {code}
> Modification to newChannels should be protected by synchronized block.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to