dajac commented on code in PR #12388:
URL: https://github.com/apache/kafka/pull/12388#discussion_r916162985
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -1050,10 +1051,18 @@ public synchronized void requestRejoin(final String
shortReason) {
public synchronized void requestRejoin(final String shortReason,
final String fullReason) {
log.info("Request joining group due to: {}", fullReason);
- this.rejoinReason = shortReason;
+ this.rejoinReason = truncateIfRequired(shortReason);
Review Comment:
In my opinion, it would be better to do this when the JoinGroupRequestData
is created. It is here:
https://github.com/apache/kafka/blob/64ac302b1c6baa4b28e6fb90776985ac242d41e3/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java#L563
This ensures that we cover all the paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
