tyamashi-oss commented on code in PR #12296:
URL: https://github.com/apache/kafka/pull/12296#discussion_r916537625
##########
core/src/test/scala/unit/kafka/log/LogCleanerTest.scala:
##########
@@ -1856,7 +1856,7 @@ class LogCleanerTest {
@Test
def testReconfigureLogCleanerIoMaxBytesPerSecond(): Unit = {
val oldKafkaProps = TestUtils.createBrokerConfig(1, "localhost:2181")
- oldKafkaProps.put(KafkaConfig.LogCleanerIoMaxBytesPerSecondProp, 10000000)
+ oldKafkaProps.put(KafkaConfig.LogCleanerIoMaxBytesPerSecondProp, 10000000:
java.lang.Double)
Review Comment:
Thank you for noticing.
After checking other tests, I replaced Properties.put(Object, Object) to
Properteis.setProperty(String, String), and used string, not number. Because it
is appropriate to use string as key and value for Properties, and string values
are also used when actually creating KafkaConfig. And I also confirmed that the
previous compilation error reappeared when using 10000000L: "the result type of
an implicit conversion must be more specific than Object"
https://github.com/apache/kafka/pull/12296/commits/ba640f532ff30bd3f801613eadd2d82af02e6a8a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
