dajac commented on code in PR #12388:
URL: https://github.com/apache/kafka/pull/12388#discussion_r917912085
##########
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRequest.java:
##########
@@ -70,6 +70,21 @@ public static void validateGroupInstanceId(String id) {
});
}
+ /**
+ * Ensures that the provided {@code reason} remains within a range of 255
chars.
+ * @param reason This is the reason that is sent to the broker over the
wire
+ * as a part of {@code JoinGroupRequest}, {@code
LeaveGroupRequest}
+ * or {@code RemoveMembersFromConsumerGroupOptions} messages.
Review Comment:
nit: We can remove this line because, in the end, we also send a
LeaveGroupRequest in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]