C0urante commented on code in PR #11783:
URL: https://github.com/apache/kafka/pull/11783#discussion_r919448768
##########
tests/kafkatest/tests/connect/connect_distributed_test.py:
##########
@@ -519,6 +535,105 @@ def test_bounce(self, clean, connect_protocol):
assert success, "Found validation errors:\n" + "\n ".join(errors)
+ @cluster(num_nodes=6)
+ @matrix(clean=[True, False], connect_protocol=['sessioned', 'compatible',
'eager'])
+ def test_exactly_once_source(self, clean, connect_protocol):
+ """
+ Validates that source and sink tasks that run continuously and produce
a predictable sequence of messages
+ run correctly and deliver messages exactly once when Kafka Connect
workers undergo bounces, both clean and unclean.
Review Comment:
Yep, done.
##########
tests/kafkatest/tests/connect/connect_distributed_test.py:
##########
@@ -519,6 +535,105 @@ def test_bounce(self, clean, connect_protocol):
assert success, "Found validation errors:\n" + "\n ".join(errors)
+ @cluster(num_nodes=6)
+ @matrix(clean=[True, False], connect_protocol=['sessioned', 'compatible',
'eager'])
+ def test_exactly_once_source(self, clean, connect_protocol):
+ """
+ Validates that source and sink tasks that run continuously and produce
a predictable sequence of messages
Review Comment:
1. Good point, no, we do not.
2. I believe it is already mentioned? I've cleaned up the description a bit
but left in the "deliver messages exactly once" part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
