[
https://issues.apache.org/jira/browse/KAFKA-14073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567156#comment-17567156
]
Ashmeet Lamba edited comment on KAFKA-14073 at 7/15/22 4:13 PM:
----------------------------------------------------------------
Hi, I am new to Kafka and noticed that this issue is tagged as newbie. I would
like to pick this issue up.
I have gone through the PR attached. I also did go through the KRaft's README.
Reading through the code base I believe the changes required would be in this
file -
[BrokerMetadataListener|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala],
specifically in the lines -
[BrokerMetadataListener(L142-L148)|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala#L142-L148].
Along with the changes required to log the reason of snapshot in -
[BrokerMetadataSnapshotter|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala]
If I have understood the issue accurately - can I pick this issue?
was (Author: ashmeetlamba):
Hi, I am new Kafka and notice that this issue is marked as newbie. I was
looking to learn Scala and wanted to give this issue a try.
I have gone through the PR link attached and read the KRaft README.md to
understand what it's purpose is.
Reading through the code base I believe changes required would be in this file
-
[BrokerMetadataListener|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala],
specifically in the lines -
[BrokerMetadataListener(L142-L148)|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala#L142-L148].
Along with the changes to log the reason in
[BrokerMetadataSnapshotter|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala]
Can I pick this issue?
> Logging the reason for creating a snapshot
> ------------------------------------------
>
> Key: KAFKA-14073
> URL: https://issues.apache.org/jira/browse/KAFKA-14073
> Project: Kafka
> Issue Type: Improvement
> Reporter: dengziming
> Priority: Minor
> Labels: kraft, newbie
>
> So far we have two reasons for creating a snapshot. 1. X bytes were applied.
> 2. the metadata version changed. we should log the reason when creating
> snapshot both in the broker side and controller side. see
> https://github.com/apache/kafka/pull/12265#discussion_r915972383
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
