ijuma commented on code in PR #12365:
URL: https://github.com/apache/kafka/pull/12365#discussion_r922781755


##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -1491,20 +1495,25 @@ public void setPartition(int partition) {
 
             if (log.isTraceEnabled()) {

Review Comment:
   That's not considered best practice in Java and we don't typically do it in 
Kafka. What would be the reason to run it in tests only?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to