[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568029#comment-17568029
]
ASF GitHub Bot commented on KAFKA-13868:
----------------------------------------
tombentley commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923438915
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item"
role="menuitem">
+ <a href="#"
class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false"
aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu"
aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/";
target="_blank">
+ Apache
Homepage
+ </a>
+ </li>
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/licenses/";>
+ License
+ </a>
+ </li>
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1"
href="https://www.apache.org/events/current-event";>
+ Events
+ </a>
+ </li>
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1"
href="https://www.apache.org/foundation/sponsorship.html"; target="_blank">
+
Sponsorship
+ </a>
+ </li>
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1"
href="https://www.apache.org/foundation/thanks.html";>
+ Sponsors
+ </a>
+ </li>
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/security/";>
Review Comment:
The Apache policy allows to link to a project specific page, and we already
have this at https://kafka.apache.org/project-security. I think using that
would be better that linking to the overarching Apache security page.
##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
</li>
</ul>
</li>
+ <li class="top-nav-item"
role="menuitem">
+ <a href="#"
class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false"
aria-controls="nav-community-menu">
+ Apache Software
+ </a>
+ <ul class="top-nav-menu"
aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+ <li
class="top-nav-menu-item" role="menuitem">
+ <a
class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/";
target="_blank">
+ Apache
Homepage
Review Comment:
The policy says
> This may either be a featured link in your main navigation system or a
text link in your Main homepage text. A best practice is to include a short
sentence or paragraph on the homepage noting that this project is an Apache
project, and is part of a larger community of developers and users.
So making the 'Apache' part of the homepage a link, and including this
information further down (after the "Trust and Ease of Use" section) should
also be acceptable, and indeed closer to the best practice.
Wdyt?
> Website updates to satisfy Apache privacy policies
> --------------------------------------------------
>
> Key: KAFKA-13868
> URL: https://issues.apache.org/jira/browse/KAFKA-13868
> Project: Kafka
> Issue Type: Bug
> Components: website
> Reporter: Mickael Maison
> Assignee: Divij Vaidya
> Priority: Critical
>
> The ASF has updated its privacy policy and all websites must be compliant.
> The full guidelines can be found in
> [https://privacy.apache.org/faq/committers.html]
> The Kafka website has a few issues, including:
> - It's missing a link to the privacy policy:
> [https://privacy.apache.org/policies/privacy-policy-public.html]
> - It's using Google Analytics
> - It's using Google Fonts
> - It's using scripts hosted on Cloudflare CDN
> - Embedded videos don't have an image placeholder
> As per the email sent to the PMC, all updates have to be done by July 22.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
