tombentley commented on code in PR #11478:
URL: https://github.com/apache/kafka/pull/11478#discussion_r923511503
##########
core/src/main/scala/kafka/utils/CoreUtils.scala:
##########
@@ -252,16 +255,62 @@ object CoreUtils {
listenerListToEndPoints(listeners, securityProtocolMap, true)
}
+ def validateOneIsIpv4AndOtherIpv6(first: String, second: String): Boolean =
+ (inetAddressValidator.isValidInet4Address(first) &&
inetAddressValidator.isValidInet6Address(second)) ||
Review Comment:
Looking at the implementation of `isValidInet6Address` it seems to accept
prefix sizes and zone ids. AFAIU it would not make sense to accept an address
with a prefix here: We're expecting to ultimately bind to a single address. I'm
not sure whether we need to accept/support zone/scope here either, for the same
reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
