ashmeet13 commented on PR #12414: URL: https://github.com/apache/kafka/pull/12414#issuecomment-1189398064
@dengziming I have made the changes requested. I have also made the changes in `QuorumController.maybeGenerateSnapshot` to log the reason for the snapshot being generated. `maybeGenerateSnapshot` seemed to be a better place than `QuorumController.SnapshotGeneratorManager.createSnapshotGenerator` since it already had logs for starting a snapshot. Also, it seems like `QuorumController` only creates a snapshot when max bytes are exceeded, I couldn't find it calling the snapshot generator for the reason metadata version changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
